From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753203AbbG1Ehd (ORCPT ); Tue, 28 Jul 2015 00:37:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:35033 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbG1Ehb (ORCPT ); Tue, 28 Jul 2015 00:37:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,560,1432623600"; d="scan'208";a="736872332" Date: Tue, 28 Jul 2015 10:09:11 +0530 From: Vinod Koul To: "Luis R. Rodriguez" Cc: mingo@elte.hu, bp@suse.de, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, "Luis R. Rodriguez" , x86@kernel.org Subject: Re: [PATCH v3 1/2] drivers/dma/iop-adma: Use dma_alloc_writecombine() kernel-style Message-ID: <20150728043911.GU29916@localhost> References: <1438041882-10837-1-git-send-email-mcgrof@do-not-panic.com> <1438041882-10837-2-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438041882-10837-2-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 05:04:41PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > dma_alloc_writecombine()'s call and return value check is tangled in all > in one call. Untangle both calls according to kernel coding style. Acked-by: Vinod Koul -- ~Vinod