From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755261AbbG1Hxg (ORCPT ); Tue, 28 Jul 2015 03:53:36 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:36502 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbbG1Hxd (ORCPT ); Tue, 28 Jul 2015 03:53:33 -0400 Date: Tue, 28 Jul 2015 08:53:29 +0100 From: Lee Jones To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, Greg Kroah-Hartman , Vinod Koul , Mika Westerberg , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Heikki Krogerus , Jarkko Nikula , "Wysocki, Rafael J" , mturquette@baylibre.com, sboyd@codeaurora.org Subject: Re: [PATCH v6 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit Message-ID: <20150728075329.GW21114@x1> References: <1438009443-55317-1-git-send-email-andriy.shevchenko@linux.intel.com> <1438009443-55317-8-git-send-email-andriy.shevchenko@linux.intel.com> <20150728074829.GU21114@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150728074829.GU21114@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FAO Vinod, On Tue, 28 Jul 2015, Lee Jones wrote: > On Mon, 27 Jul 2015, Andy Shevchenko wrote: > > > Intel integrated DMA (iDMA) 64-bit is a specific IP that is used as a part of > > LPSS devices such as HSUART or SPI. The iDMA IP is attached for private > > usage on each host controller independently. > > > > While it has similarities with Synopsys DesignWare DMA, the following > > distinctions doesn't allow to use the existing driver: > > - 64-bit mode with corresponding changes in Hardware Linked List data structure > > - many slight differences in the channel registers > > > > Moreover this driver is based on the DMA virtual channels framework that helps > > to make the driver cleaner and easy to understand. > > > > Signed-off-by: Andy Shevchenko > > --- > > drivers/dma/Kconfig | 8 + > > drivers/dma/Makefile | 1 + > > drivers/dma/idma64.c | 710 +++++++++++++++++++++++++++++++++++++++++++++++++++ > > drivers/dma/idma64.h | 233 +++++++++++++++++ > > 4 files changed, 952 insertions(+) > > create mode 100644 drivers/dma/idma64.c > > create mode 100644 drivers/dma/idma64.h > > Applied, thanks. Pull request to follow. Will send out a pull request when I have Vinod's Ack. [...] Patches will still be applied to -next for soak testing though. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog