From: Michal Hocko <mhocko@kernel.org>
To: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vivek Goyal <vgoyal@redhat.com>,
linux-doc@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI
Date: Tue, 28 Jul 2015 10:01:03 +0200 [thread overview]
Message-ID: <20150728080103.GD24972@dhcp22.suse.cz> (raw)
In-Reply-To: <55B6E2A3.8070004@hitachi.com>
On Tue 28-07-15 11:02:11, Hidehiro Kawai wrote:
[...]
> > Something like
> [...]
> > +void nmi_panic(const char *fmt, ...)
>
> Since we can't directly pass variable arguments to a subroutine,
Sure, I was just too lazy to finish this as it was just an illustration
of the idea.
> we have to use a macro or do like this:
>
> void nmi_panic(const char *msg)
> {
> ...
> panic("%s", msg);
> }
>
> If there is no objection, I'm going to use a macro.
Your other patch needs panic_cpu externally visible so the macro should
be OK.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-07-28 8:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 1:58 [V2 PATCH 0/3] x86: Fix panic vs. NMI issues Hidehiro Kawai
2015-07-27 1:58 ` [V2 PATCH 3/3] x86/apic: Introduce noextnmi boot option Hidehiro Kawai
2015-07-27 1:58 ` [V2 PATCH 1/3] x86/panic: Fix re-entrance problem due to panic on NMI Hidehiro Kawai
2015-07-27 14:34 ` Michal Hocko
2015-07-28 2:02 ` Hidehiro Kawai
2015-07-28 8:01 ` Michal Hocko [this message]
2015-07-29 5:48 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29 8:23 ` Michal Hocko
2015-07-29 9:09 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-29 9:21 ` Michal Hocko
2015-07-30 1:45 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 7:33 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 7:55 ` Michal Hocko
2015-07-30 8:06 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 7:48 ` Michal Hocko
2015-07-30 11:55 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-30 12:27 ` Michal Hocko
2015-07-31 11:23 ` 河合英宏 / KAWAI，HIDEHIRO
2015-08-04 8:56 ` Michal Hocko
2015-08-04 11:53 ` 河合英宏 / KAWAI，HIDEHIRO
2015-07-27 1:58 ` [V2 PATCH 2/3] kexec: Fix race between panic() and crash_kexec() called directly Hidehiro Kawai
2015-07-27 14:55 ` Michal Hocko
2015-07-28 2:15 ` Hidehiro Kawai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728080103.GD24972@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox