From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933630AbbG1KPy (ORCPT ); Tue, 28 Jul 2015 06:15:54 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:17396 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932485AbbG1KPw (ORCPT ); Tue, 28 Jul 2015 06:15:52 -0400 Date: Tue, 28 Jul 2015 13:15:25 +0300 From: Dan Carpenter To: Jignesh R Patel Cc: Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem Message-ID: <20150728101525.GC5180@mwanda> References: <1438077513-17898-1-git-send-email-jigneshpatel0103@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438077513-17898-1-git-send-email-jigneshpatel0103@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject isn't right. You aren't patch checkpatch.pl itself you're patching android. The version doesn't go in the subject. The subject is too vague. On Tue, Jul 28, 2015 at 03:28:33PM +0530, Jignesh R Patel wrote: > From: Jignesh R Patel Not needed. > > This patch fix coding style problem of more then > 80 character in one line. This patch does not change any > logic. > > Signed-off-by: Jignesh R Patel > --- > drivers/staging/android/ion/ion_cma_heap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c > index 86b91fd..4a9a7bd 100644 > --- a/drivers/staging/android/ion/ion_cma_heap.c > +++ b/drivers/staging/android/ion/ion_cma_heap.c > @@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!info->table) > goto free_mem; > > - if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) > + if (dma_get_sgtable(dev, info->table, info->cpu_addr, > + info->handle, len)) This isn't the right way to do it. I suppose the right thing is: if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len)) regards, dan carpenter