From: Jean-Francois Moine <moinejf@free.fr>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RFC] drm/i2c: tda998x: dead-code or unhandled error condition ?
Date: Tue, 28 Jul 2015 10:25:26 +0200 [thread overview]
Message-ID: <20150728102527.528f7d51@armhf> (raw)
In-Reply-To: <1433941128-19798-1-git-send-email-hofrat@osadl.org>
On Wed, 10 Jun 2015 14:58:48 +0200
Nicholas Mc Guire <hofrat@osadl.org> wrote:
> event API conformance testing with coccinelle spatches are being
> used to locate API usage inconsistencies this triggert with:
> ./drivers/gpu/drm/i2c/tda998x_drv.c:1062
> incorrect check for negative return
>
> The return of wait_event_timeout is always >= 0, thus the negative
> check was effectively being ignoring - as the timeout will be checked
> a few lines below the error condition being checked here seems to be
> wrong or this is simply dead code which would be my guess as the
> timeout condition check covers the wait-queue related failure condition.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Jean-Francois Moine <moinejf@free.fr>
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
prev parent reply other threads:[~2015-07-28 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 12:58 [PATCH RFC] drm/i2c: tda998x: dead-code or unhandled error condition ? Nicholas Mc Guire
2015-07-28 8:25 ` Jean-Francois Moine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728102527.528f7d51@armhf \
--to=moinejf@free.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox