From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755429AbbG1LgE (ORCPT ); Tue, 28 Jul 2015 07:36:04 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34870 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbbG1LgC (ORCPT ); Tue, 28 Jul 2015 07:36:02 -0400 Date: Tue, 28 Jul 2015 17:05:54 +0530 From: Sudip Mukherjee To: Mario Bambagini Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, andreas.dilger@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] staging: lustre: fix bad alignment Message-ID: <20150728113554.GE15027@sudip-pc> References: <1438024825-18120-1-git-send-email-mario.bambagini@gmail.com> <1438024825-18120-3-git-send-email-mario.bambagini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438024825-18120-3-git-send-email-mario.bambagini@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 09:20:23PM +0200, Mario Bambagini wrote: > This patch fixes 8 bad alignments. When a line is split on > more than one line, the other lines must be aligned with > paranthesis. > > Signed-off-by: Mario Bambagini > --- > drivers/staging/lustre/lustre/llite/llite_capa.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c > index 1f72066..a3b3c46 100644 > --- a/drivers/staging/lustre/lustre/llite/llite_capa.c > +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c > @@ -71,7 +71,7 @@ static unsigned long long ll_capa_renewal_retries; > static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa); > > static inline void update_capa_timer(struct obd_capa *ocapa, > - unsigned long expiry) > + unsigned long expiry) This bad alignment was created in your previous patch of the series. You should have aligned it when you splitted the line for 80 char limit. regards sudip