From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754865AbbG1LrJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jul 2015 07:47:09 -0400
Received: from mail-pd0-f180.google.com ([209.85.192.180]:34907 "EHLO
	mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752431AbbG1LrG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jul 2015 07:47:06 -0400
Date: Tue, 28 Jul 2015 17:16:56 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nitin Kuppelur <nitinkuppelur@gmail.com>,
        Vaishali Thakkar <vthakkar1994@gmail.com>,
        Tapasweni Pathak <tapaswenipathak@gmail.com>,
        Daniel Baluta <daniel.baluta@intel.com>,
        Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
        Max Perepelitsyn <mperepelitsyn@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Dogukan Ergun <dogukan.ergun@gmail.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
Message-ID: <20150728114656.GF15027@sudip-pc>
References: <cover.1438057939.git.stillcompiling@gmail.com>
 <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 27, 2015 at 09:41:10PM -0700, Joshua Clayton wrote:
> r8712_get_ndis_wlan_bssid_ex_sz has a "6 * sizeof(unsigned long)"
> where the underlying struct has a 6 * unsigned char.
> Simplify the calculation by just subtracting the variable part from
> the size of the struct.
> 
> This also gets rid of a use of typedef NDIS_802_11_RATES_EX
> 
> Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
> ---
<snip>
>  
>  u8 *r8712_get_capability_from_ie(u8 *ie)
> -- 
> 2.4.6
> 
> From: Joshua Clayton <stillcompiling@gmail.com>
> To: Larry Finger <Larry.Finger@lwfinger.net>,
> 	Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
> 	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> 	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
> 	Nitin Kuppelur <nitinkuppelur@gmail.com>,
> 	Joshua Clayton <stillcompiling@gmail.com>,
> 	Vaishali Thakkar <vthakkar1994@gmail.com>,
> 	Tapasweni Pathak <tapaswenipathak@gmail.com>,
> 	Daniel Baluta <daniel.baluta@intel.com>,
> 	Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
> 	Max Perepelitsyn <mperepelitsyn@gmail.com>,
> 	Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
> 	Cristina Opriceana <cristina.opriceana@gmail.com>,
> 	Dogukan Ergun <dogukan.ergun@gmail.com>,
> 	Julia Lawall <Julia.Lawall@lip6.fr>,
> 	Dan Carpenter <dan.carpenter@oracle.com>,
> 	Haneen Mohammed <hamohammed.sa@gmail.com>,
> 	Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> Cc: devel@driverdev.osuosl.org,
> 	linux-kernel@vger.kernel.org
> Subject: [PATCH V3 1/8] staging: rtl8712: fix buggy size calculation
> Date: Mon, 27 Jul 2015 21:41:10 -0700
> Message-Id: <305999598d7738feabdc8e5df5400b3e7be7f5ed.1438057939.git.stillcompiling@gmail.com>
> X-Mailer: git-send-email 2.4.6
> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
> References: <cover.1438057939.git.stillcompiling@gmail.com>
> In-Reply-To: <cover.1438057939.git.stillcompiling@gmail.com>
> References: <cover.1438057939.git.stillcompiling@gmail.com>

Something is wrong. The same patch is getting repeated in the same mail
multiple times. I deleted almost 2500 lines after this before sending
this reply. See how your patch is looking like:
http://www.gossamer-threads.com/lists/linux/kernel/2224869

regards
sudip