public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: David Drysdale <drysdale@google.com>,
	linux-api@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Eric B Munson <emunson@akamai.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Vivek Goyal <vgoyal@redhat.com>,
	Alexei Starovoitov <ast@plumgrid.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Kees Cook <keescook@chromium.org>,
	Miklos Szeredi <mszeredi@suse.cz>,
	Milosz Tanski <milosz@adfin.com>, Fam Zheng <famz@redhat.com>,
	Josh Triplett <josh@joshtriplett.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/1] Document how to add a new syscall
Date: Tue, 28 Jul 2015 16:19:20 +0200	[thread overview]
Message-ID: <20150728141920.GC19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <55B78AB4.2010807@osg.samsung.com>

On Tue, Jul 28, 2015 at 07:59:16AM -0600, Shuah Khan wrote:
> On 07/28/2015 05:41 AM, David Drysdale wrote:
> > Given that I've gotten some of the details wrong in the past (and I've
> > seen others do likewise), I thought it might be helpful to collate the
> > best practices for adding a new system call to the kernel.
> > 
> > Apologies for the wide circulation -- I've tried to include folk who've
> > recently added or proposed a system call, as they're most likely to
> > have opinions on:
> >  - whether this a useful addition to Documentation/
> >  - whether the details of the advice are correct and complete.
> > 
> > Shuah, is there anything more that should be added for the Testing
> > section in particular?
> > 
> 
> David,
> 
> Looks good. You could add a one liner on in some cases, it might be
> necessary to install headers before test compiles. Other than that,
> the information looks good.

For perf we still use the syscall() wrapper and we have hardcoded
(fallback) syscall numbers in there in case they've not yet reached
unistd.h.

People update their kernels far more often than their userspace headers.

  reply	other threads:[~2015-07-28 14:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 11:41 [PATCH RFC 0/1] Document how to add a new syscall David Drysdale
2015-07-28 11:41 ` [PATCH RFC 1/1] Documentation: describe how to add a system call David Drysdale
2015-07-28 14:14   ` Eric B Munson
2015-07-28 16:43   ` Kees Cook
2015-07-28 17:13     ` David Drysdale
2015-07-28 17:17       ` Kees Cook
2015-07-28 21:22   ` Randy Dunlap
2015-07-28 13:59 ` [PATCH RFC 0/1] Document how to add a new syscall Shuah Khan
2015-07-28 14:19   ` Peter Zijlstra [this message]
2015-07-28 16:02     ` David Drysdale
2015-07-28 16:41       ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728141920.GC19282@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=ast@plumgrid.com \
    --cc=corbet@lwn.net \
    --cc=dh.herrmann@gmail.com \
    --cc=drysdale@google.com \
    --cc=emunson@akamai.com \
    --cc=famz@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=josh@joshtriplett.org \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=milosz@adfin.com \
    --cc=mingo@redhat.com \
    --cc=mszeredi@suse.cz \
    --cc=mtk.manpages@gmail.com \
    --cc=oleg@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=vgoyal@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox