From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbbG1O1R (ORCPT ); Tue, 28 Jul 2015 10:27:17 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45417 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbbG1O1Q (ORCPT ); Tue, 28 Jul 2015 10:27:16 -0400 Date: Tue, 28 Jul 2015 16:27:13 +0200 From: Pavel Machek To: Viresh Kumar Cc: Rafael Wysocki , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, b.zolnierkie@samsung.com, nm@ti.com, sboyd@codeaurora.org, Tomasz Figa , Michael Turquette , Javier Martinez Canillas , Thomas Abraham , Greg Kroah-Hartman , Len Brown , open list Subject: Re: [PATCH 1/4] opp: add dev_pm_opp_is_turbo() helper Message-ID: <20150728142713.GB17745@amd> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2015-07-28 16:50:00, Viresh Kumar wrote: > From: Bartlomiej Zolnierkiewicz > > Add dev_pm_opp_is_turbo() helper to verify if an opp is to be used only > for turbo mode or not. > > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Viresh Kumar > --- > drivers/base/power/opp.c | 30 ++++++++++++++++++++++++++++++ > include/linux/pm_opp.h | 7 +++++++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c > index b38f2600d797..a0c54058c4dd 100644 > --- a/drivers/base/power/opp.c > +++ b/drivers/base/power/opp.c > @@ -281,6 +281,36 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq); > > /** > + * dev_pm_opp_is_turbo() - Returns true if opp was trubo OPP Typo. And this is not exactly most helpful comment. opp is turbo... returns if opp was turbo. Explanation what "turbo" means in this context would be nice. I'm pretty sure it is not about air compression :-). > + * Return: true if opp is turbo opp, else false. Duplicate from above. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html