From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932191AbbG1OdG (ORCPT ); Tue, 28 Jul 2015 10:33:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:52378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbbG1OdC (ORCPT ); Tue, 28 Jul 2015 10:33:02 -0400 Date: Tue, 28 Jul 2015 11:32:57 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Andi Kleen , linux-kernel@vger.kernel.org, Andi Kleen , jolsa@kernel.org Subject: Re: [PATCH] perf, tools, stat: Fix perf stat -T Message-ID: <20150728143257.GC575@kernel.org> References: <1438039491-22091-1-git-send-email-andi@firstfloor.org> <20150728141006.GE28175@krava.brq.redhat.com> <20150728142132.GB575@kernel.org> <20150728143018.GF28175@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150728143018.GF28175@krava.brq.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jul 28, 2015 at 04:30:18PM +0200, Jiri Olsa escreveu: > On Tue, Jul 28, 2015 at 11:21:32AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 28, 2015 at 04:10:06PM +0200, Jiri Olsa escreveu: > > > On Mon, Jul 27, 2015 at 04:24:51PM -0700, Andi Kleen wrote: > > > > +++ b/tools/perf/util/stat-shadow.c > > > > + update_stats(&runtime_cycles_in_tx_stats[ctx][cpu], count[0]); > > > oops, looks like copy&paste issue.. thanks > > > we now print comment line if the avg is 0, but I think it's ok > > > Acked-by: Jiri Olsa > > This affects just perf/core, right? > I guess, dont think it's an urgent one.. Andi, please speak up ;-) I'm not talking about it being urgent or not, I'm talking about it being a bug present only in perf/core or if this is something that is in perf/urgent, i.e. affects what is in Linus's upstream tree, etc. - Arnaldo