Re: [PATCH 1/5] iTCO_wdt: Expose watchdog properties using platform data

Lee Jones
2015-07-27T21:32:42Z

On Mon, 27 Jul 2015, Matt Fleming wrote:

> On Mon, 27 Jul, at 04:33:44PM, Lee Jones wrote:
> > On Mon, 27 Jul 2015, Matt Fleming wrote:
> >
> > > From: Matt Fleming <matt.fleming@intel.com>
> > >
> > > Intel Sunrisepoint (Skylake PCH) has the iTCO watchdog accessible across
> > > the SMBus, unlike previous generations of PCH/ICH where it was on the
> > > LPC bus. Because it's on the SMBus, it doesn't make sense to pass around
> > > a 'struct lpc_ich_info', and leaking the type of bus into the iTCO
> > > watchdog driver is kind of backwards anyway.
> > >
> > > This change introduces a new 'struct iTCO_wdt_platform_data' for use
> > > inside the iTCO watchdog driver and by the upcoming Intel Sunrisepoint
> > > code, which neatly avoids having to include lpc_ich headers in the i801
> > > i2c driver.
> > >
> > > A simple translation layer is provided for converting from the existing
> > > 'struct lpc_ich_info' inside the lpc_ich mfd driver.
> >
> > Is this patch related to Andy's patch-set?
> >
> > https://lkml.org/lkml/2015/7/27/599
>
> Nope, the two are independent.
>
> > > Cc: Peter Tyser <ptyser@xes-inc.com>
> > > Cc: Samuel Ortiz <sameo@linux.intel.com>
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > Cc: Wim Van Sebroeck <wim@iguana.be>
> > > Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> > > ---
> > > drivers/mfd/lpc_ich.c | 32 +++++++++++++++++++++++++++++---
> > > drivers/watchdog/Kconfig | 2 +-
> > > drivers/watchdog/iTCO_wdt.c | 11 +++++------
> > > include/linux/mfd/lpc_ich.h | 6 ------
> > > include/linux/platform_data/iTCO_wdt.h | 18 ++++++++++++++++++
> > > 5 files changed, 53 insertions(+), 16 deletions(-)
> > > create mode 100644 include/linux/platform_data/iTCO_wdt.h
> >
> > How are all of these changes related?
>
> They create the platform data struct and use it in lpc_ich and iTCO_wdt.
> The Kconfig change shouldn't have snuck into this patch though, that's
> wrong, sorry.
>
> > Why do they all have to be in a single patch?
>
> I'll happily split them into more patches if you'd prefer. Maybe one
> that introduces the platform data structure and then a separate one that
> uses it in iTCO_wdt and lpc_ich?
>
> Technically we could also split the change between iTCO_wdt and lpc_ich,
> but then we'd be passing in an 'lpc_ich_info' and pulling out a
> 'iTCO_wdt_platform_data' and that just seems crazy.

If it's possible to split them up per subsystem, that would be ideal.
Cross-subsystem patches are a pain in a backside.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog