From: Marek Vasut <marex@denx.de>
To: Michal Suchanek <hramrach@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Brian Norris" <computersforpeace@gmail.com>,
" Rafał Miłecki" <zajec5@gmail.com>,
"Huang Shijie" <shijie.huang@intel.com>,
"Ben Hutchings" <ben@decadent.org.uk>,
"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mtd: spi-nor: Add Pm25LD020 and GD25Q41B chip ID.
Date: Tue, 28 Jul 2015 16:33:47 +0200 [thread overview]
Message-ID: <201507281633.47322.marex@denx.de> (raw)
In-Reply-To: <c9120b0590effa9ea7e60ef805782de70b5336ea.1438073915.git.hramrach@gmail.com>
On Tuesday, July 28, 2015 at 11:07:58 AM, Michal Suchanek wrote:
> First chip reads Pm25LD020 or Pm25L0020. Found on some WD HDD PCB.
> Identified as PMC Pm25LD020.
> Flash read does not return consistent data which explains why the disk
> died.
>
> Second chip reads something like 25Q41BT. Found on Esspif ESP8266 based
> ESP-01 board. Identified as Giga Devices GD25Q41B.
>
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index cba3bd0..e55689d 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -558,6 +558,7 @@ static const struct spi_device_id spi_nor_ids[] = {
> { "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE) },
>
> /* GigaDevice */
> + { "gd25q41b", INFO(0xc84013, 0, 64 * 1024, 8, SECT_4K) },
> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) },
> { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) },
> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) },
> @@ -601,6 +602,7 @@ static const struct spi_device_id spi_nor_ids[] = {
> /* PMC */
> { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) },
> { "pm25lv010", INFO(0, 0, 32 * 1024, 4, SECT_4K_PMC) },
> + { "pm25ld020", INFO(0x7f9d22, 0, 64 * 1024, 4, SECT_4K) },
> { "pm25lq032", INFO(0x7f9d46, 0, 64 * 1024, 64, SECT_4K) },
>
> /* Spansion -- single (large) sector size only, at least
You might want to split this into two patches, but see my comment on 1/2
and please wait for Brian's confirmation there before you do anything.
Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-07-28 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1438073915.git.hramrach@gmail.com>
[not found] ` <cb552b89554df49d1e6a24ce45b48c9e203f3b37.1438073915.git.hramrach@gmail.com>
2015-07-28 14:33 ` [PATCH 1/2] mtd: spi-nor: Add GD25LQ32C 1.8V SPI NOR flash ID Marek Vasut
2015-07-28 14:36 ` Michal Suchanek
2015-07-28 14:38 ` Marek Vasut
2015-07-28 14:52 ` Michal Suchanek
2015-07-28 15:19 ` Rafał Miłecki
2015-07-28 15:48 ` Marek Vasut
[not found] ` <c9120b0590effa9ea7e60ef805782de70b5336ea.1438073915.git.hramrach@gmail.com>
2015-07-28 14:33 ` Marek Vasut [this message]
2015-07-28 15:22 ` [PATCH 2/2] mtd: spi-nor: Add Pm25LD020 and GD25Q41B chip ID Rafał Miłecki
2015-07-28 15:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201507281633.47322.marex@denx.de \
--to=marex@denx.de \
--cc=beanhuo@micron.com \
--cc=ben@decadent.org.uk \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hramrach@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie.huang@intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox