From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439AbbG1Odx (ORCPT ); Tue, 28 Jul 2015 10:33:53 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:58594 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932417AbbG1Odu (ORCPT ); Tue, 28 Jul 2015 10:33:50 -0400 X-Auth-Info: hzf4NwZ7sF+DyMrYX5lU/L34M+ZQBMW/zH0tEque2Wo= From: Marek Vasut To: Michal Suchanek Subject: Re: [PATCH 2/2] mtd: spi-nor: Add Pm25LD020 and GD25Q41B chip ID. Date: Tue, 28 Jul 2015 16:33:47 +0200 User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; ) Cc: David Woodhouse , Brian Norris , " =?utf-8?q?Rafa=C5=82?= =?utf-8?q?_Mi=C5=82ecki?=" , Huang Shijie , Ben Hutchings , "Bean Huo =?utf-8?q?=E9=9C=8D=E6=96=8C=E6=96=8C?= \(beanhuo\)" , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201507281633.47322.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 28, 2015 at 11:07:58 AM, Michal Suchanek wrote: > First chip reads Pm25LD020 or Pm25L0020. Found on some WD HDD PCB. > Identified as PMC Pm25LD020. > Flash read does not return consistent data which explains why the disk > died. > > Second chip reads something like 25Q41BT. Found on Esspif ESP8266 based > ESP-01 board. Identified as Giga Devices GD25Q41B. > > Signed-off-by: Michal Suchanek > --- > drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index cba3bd0..e55689d 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -558,6 +558,7 @@ static const struct spi_device_id spi_nor_ids[] = { > { "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE) }, > > /* GigaDevice */ > + { "gd25q41b", INFO(0xc84013, 0, 64 * 1024, 8, SECT_4K) }, > { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) }, > { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) }, > { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) }, > @@ -601,6 +602,7 @@ static const struct spi_device_id spi_nor_ids[] = { > /* PMC */ > { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) }, > { "pm25lv010", INFO(0, 0, 32 * 1024, 4, SECT_4K_PMC) }, > + { "pm25ld020", INFO(0x7f9d22, 0, 64 * 1024, 4, SECT_4K) }, > { "pm25lq032", INFO(0x7f9d46, 0, 64 * 1024, 64, SECT_4K) }, > > /* Spansion -- single (large) sector size only, at least You might want to split this into two patches, but see my comment on 1/2 and please wait for Brian's confirmation there before you do anything. Thanks! Best regards, Marek Vasut