From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753112AbbG1Pth (ORCPT ); Tue, 28 Jul 2015 11:49:37 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:59196 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbbG1Ptg convert rfc822-to-8bit (ORCPT ); Tue, 28 Jul 2015 11:49:36 -0400 X-Auth-Info: DkDOVzlnXCDAYX63oBJlYIdGNzU5qbDWv2BGAQ29Cio= From: Marek Vasut To: =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= Subject: Re: [PATCH 2/2] mtd: spi-nor: Add Pm25LD020 and GD25Q41B chip ID. Date: Tue, 28 Jul 2015 17:49:31 +0200 User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; ) Cc: Michal Suchanek , David Woodhouse , Brian Norris , Huang Shijie , Ben Hutchings , "Bean Huo =?utf-8?q?=E9=9C=8D=E6=96=8C=E6=96=8C?= (beanhuo)" , "linux-mtd@lists.infradead.org" , Linux Kernel Mailing List References: <201507281633.47322.marex@denx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201507281749.31916.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 28, 2015 at 05:22:17 PM, Rafał Miłecki wrote: > On 28 July 2015 at 16:33, Marek Vasut wrote: > > On Tuesday, July 28, 2015 at 11:07:58 AM, Michal Suchanek wrote: > >> First chip reads Pm25LD020 or Pm25L0020. Found on some WD HDD PCB. > >> Identified as PMC Pm25LD020. > >> Flash read does not return consistent data which explains why the disk > >> died. > >> > >> Second chip reads something like 25Q41BT. Found on Esspif ESP8266 based > >> ESP-01 board. Identified as Giga Devices GD25Q41B. > >> > >> Signed-off-by: Michal Suchanek > >> --- > >> > >> drivers/mtd/spi-nor/spi-nor.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/mtd/spi-nor/spi-nor.c > >> b/drivers/mtd/spi-nor/spi-nor.c index cba3bd0..e55689d 100644 > >> --- a/drivers/mtd/spi-nor/spi-nor.c > >> +++ b/drivers/mtd/spi-nor/spi-nor.c > >> @@ -558,6 +558,7 @@ static const struct spi_device_id spi_nor_ids[] = { > >> > >> { "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE) > >> }, > >> > >> /* GigaDevice */ > >> > >> + { "gd25q41b", INFO(0xc84013, 0, 64 * 1024, 8, SECT_4K) }, > >> > >> { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K) }, > >> { "gd25lq32c", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K) }, > >> { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K) }, > >> > >> @@ -601,6 +602,7 @@ static const struct spi_device_id spi_nor_ids[] = { > >> > >> /* PMC */ > >> { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) > >> }, { "pm25lv010", INFO(0, 0, 32 * 1024, 4, > >> SECT_4K_PMC) }, > >> > >> + { "pm25ld020", INFO(0x7f9d22, 0, 64 * 1024, 4, SECT_4K) }, > >> > >> { "pm25lq032", INFO(0x7f9d46, 0, 64 * 1024, 64, SECT_4K) }, > >> > >> /* Spansion -- single (large) sector size only, at least > > > > You might want to split this into two patches, but see my comment on 1/2 > > and please wait for Brian's confirmation there before you do anything. > > Since these flashes are from 2 different vendors, it may make sense to > use 2 separated patches. I don't care too much however. > > Adding these entries is OK in general. Thanks for clarifying, I'll make sure to remember this :) Best regards, Marek Vasut