From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] toshiba_acpi: Add set_fan_status function
Date: Tue, 28 Jul 2015 20:37:30 -0700 [thread overview]
Message-ID: <20150729033730.GB3171@vmdeb7> (raw)
In-Reply-To: <1438046548-3081-1-git-send-email-coproscefalo@gmail.com>
On Mon, Jul 27, 2015 at 07:22:23PM -0600, Azael Avalos wrote:
> This patch adds a new function named "set_fan_status" to complement
> its get* counterpart, as well as to avoid code duplication between
> "fan_proc_write" and "fan_store".
>
> Also, both functions (get*, set*) are now checking for TOS_FAILURE,
> TOS_NOT_SUPPORTED and TOS_SUCCESS (to be on par with the rest of the
> HCI/SCI functions), printing an error message, returning -ENODEV and
> zero respectively.
>
> The proc and sysfs functions were updated to reflect these changes as
> well, returning -EIO for proc, and propagating the error value on the
> sysfs functions.
>
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
Queued, thanks Azael!
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-07-29 4:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 1:22 [PATCH v2] toshiba_acpi: Add set_fan_status function Azael Avalos
2015-07-28 1:22 ` [PATCH v2 0/4] toshiba_acpi: Refactor *{get, set} and *available functions Azael Avalos
2015-07-28 1:22 ` [PATCH v2 1/4] toshiba_acpi: Change *available functions return type Azael Avalos
2015-07-29 3:46 ` Darren Hart
2015-07-28 1:22 ` [PATCH v2 2/4] toshiba_acpi: Remove "*not supported" feature prints Azael Avalos
2015-07-29 3:50 ` Darren Hart
2015-07-28 1:22 ` [PATCH v2 3/4] toshiba_acpi: Refactor *{get, set} functions return value Azael Avalos
2015-07-29 3:35 ` Darren Hart
2015-07-28 1:22 ` [PATCH v2 4/4] toshiba_acpi: Bump driver version to 0.23 Azael Avalos
2015-07-29 3:37 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729033730.GB3171@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox