From: Darren Hart <dvhart@infradead.org>
To: Azael Avalos <coproscefalo@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] toshiba_acpi: Change *available functions return type
Date: Tue, 28 Jul 2015 20:46:21 -0700 [thread overview]
Message-ID: <20150729034621.GC3171@vmdeb7> (raw)
In-Reply-To: <1438046548-3081-3-git-send-email-coproscefalo@gmail.com>
On Mon, Jul 27, 2015 at 07:22:25PM -0600, Azael Avalos wrote:
> This patch changes the *available functions return type from int to
> void.
>
> The checks for support of their respective features are done inside
> such functions and there was no need to return anything as we can
> flag the queried feature as supported inside these functions.
>
> The code was adapted accordingly to these changes and two new
> variables were created and another was changed from uint to bool.
>
> While at the neighborhood, some of the functions were cleaned from
Please consider this a red flag in the future. "While in the neighborhood" means
you need to split the patch across distinct functional boundaries.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-07-29 5:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 1:22 [PATCH v2] toshiba_acpi: Add set_fan_status function Azael Avalos
2015-07-28 1:22 ` [PATCH v2 0/4] toshiba_acpi: Refactor *{get, set} and *available functions Azael Avalos
2015-07-28 1:22 ` [PATCH v2 1/4] toshiba_acpi: Change *available functions return type Azael Avalos
2015-07-29 3:46 ` Darren Hart [this message]
2015-07-28 1:22 ` [PATCH v2 2/4] toshiba_acpi: Remove "*not supported" feature prints Azael Avalos
2015-07-29 3:50 ` Darren Hart
2015-07-28 1:22 ` [PATCH v2 3/4] toshiba_acpi: Refactor *{get, set} functions return value Azael Avalos
2015-07-29 3:35 ` Darren Hart
2015-07-28 1:22 ` [PATCH v2 4/4] toshiba_acpi: Bump driver version to 0.23 Azael Avalos
2015-07-29 3:37 ` [PATCH v2] toshiba_acpi: Add set_fan_status function Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729034621.GC3171@vmdeb7 \
--to=dvhart@infradead.org \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox