From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbbG2PXc (ORCPT ); Wed, 29 Jul 2015 11:23:32 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49385 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbbG2PXa (ORCPT ); Wed, 29 Jul 2015 11:23:30 -0400 Date: Tue, 28 Jul 2015 21:43:29 -0700 From: Darren Hart To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Corentin Chary , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] asus-laptop: Add key found on Asus F3M Message-ID: <20150729044329.GA80946@vmdeb7> References: <1437758231-5909-1-git-send-email-stlman@poczta.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437758231-5909-1-git-send-email-stlman@poczta.fm> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Łukasz, The following change seems reasonable. While it's trivial, please provide some context in your commit message. I do not merge commits with empty messages. There is always something to say. Did you see a dmesg error, the key just didn't work, the 0x6A is new on model XYZ but you don't know if others have it, it's from your personal experience, or came from an ASUS manual, etc. There is always something to provide context which will be useful to someone looking at this change - or looking for this fix when they hit this problem on an older kernel. Thanks, On Fri, Jul 24, 2015 at 07:17:11PM +0200, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach > --- > drivers/platform/x86/asus-laptop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c > index 58d29c4..f2b5d0a 100644 > --- a/drivers/platform/x86/asus-laptop.c > +++ b/drivers/platform/x86/asus-laptop.c > @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = { > {KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */ > {KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */ > {KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */ > + {KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */ > {KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */ > {KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */ > {KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */ > -- > 2.1.4 > > -- Darren Hart Intel Open Source Technology Center