From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shraddha Barke <shraddha.6596@gmail.com>
Cc: Johnny Kim <johnny.kim@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>, Dean Lee <dean.lee@atmel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Chris Park <chris.park@atmel.com>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging : wilc1000: Remove unnecessary parentheses
Date: Wed, 29 Jul 2015 11:13:25 +0300 [thread overview]
Message-ID: <20150729081325.GG5180@mwanda> (raw)
In-Reply-To: <1438147670-7590-1-git-send-email-shraddha.6596@gmail.com>
The original code is fine... I probably would write it the way you
suggest, but I can also see why people would write it the other way.
This isn't an official CodingStyle rule so I feel like the author gets
to choose. Part of the reason for CodingStyle is so that we don't run
into madness of changing every single thing all the time.
regards,
dan carpenter
prev parent reply other threads:[~2015-07-29 8:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 5:27 [PATCH] Staging : wilc1000: Remove unnecessary parentheses Shraddha Barke
2015-07-29 8:13 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150729081325.GG5180@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.park@atmel.com \
--cc=dean.lee@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rachel.kim@atmel.com \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox