From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752935AbbG2Qge (ORCPT ); Wed, 29 Jul 2015 12:36:34 -0400 Received: from casper.infradead.org ([85.118.1.10]:50596 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbbG2Qgd (ORCPT ); Wed, 29 Jul 2015 12:36:33 -0400 Date: Wed, 29 Jul 2015 18:36:28 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, tj@kernel.org, matt.fleming@intel.com, will.auld@intel.com, glenn.p.williamson@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 9/9] x86/intel_rdt: Intel haswell Cache Allocation enumeration Message-ID: <20150729163628.GZ25159@twins.programming.kicks-ass.net> References: <1435789270-27010-1-git-send-email-vikas.shivappa@linux.intel.com> <1435789270-27010-10-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435789270-27010-10-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2015 at 03:21:10PM -0700, Vikas Shivappa wrote: > + /* > + * Probe test for Haswell CPUs. Maybe elucidate and say: Probe for Haswell Server parts. As said before, probe and test mean roughly the same thing, and the model test below makes the general 'Haswell CPUs' false, because there's at least 3 other models that are also Haswell. > + */ > + if (c->x86 == 0x6 && c->x86_model == 0x3f) > + return cache_alloc_hsw_probe(); > +