From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
will.deacon@arm.com, linux@arm.linux.org.uk, ralf@linux-mips.org,
michael@amarulasolutions.com, cmetcalf@ezchip.com
Subject: Re: [RFC][PATCH 3/7] avr32: Remove finish_arch_switch()
Date: Thu, 30 Jul 2015 07:40:07 +0200 [thread overview]
Message-ID: <20150730054007.GA25446@samfundet.no> (raw)
In-Reply-To: <20150729191659.847539750@infradead.org>
Around Wed 29 Jul 2015 21:08:51 +0200 or thereabout, Peter Zijlstra wrote:
> Fold the tracing hook into switch_to() in order to remove
> finish_arch_switch().
AFAICT this should work, I do not have a nexus debugger to verify behavior.
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/include/asm/switch_to.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> --- a/arch/avr32/include/asm/switch_to.h
> +++ b/arch/avr32/include/asm/switch_to.h
> @@ -15,11 +15,13 @@
> */
> #ifdef CONFIG_OWNERSHIP_TRACE
> #include <asm/ocd.h>
> -#define finish_arch_switch(prev) \
> +#define ocd_switch(prev, next) \
> do { \
> ocd_write(PID, prev->pid); \
> - ocd_write(PID, current->pid); \
> + ocd_write(PID, next->pid); \
> } while(0)
> +#else
> +#define ocd_switch(prev, next)
> #endif
>
> /*
> @@ -38,6 +40,7 @@ extern struct task_struct *__switch_to(s
> struct cpu_context *);
> #define switch_to(prev, next, last) \
> do { \
> + ocd_switch(prev, next); \
> last = __switch_to(prev, &prev->thread.cpu_context + 1, \
> &next->thread.cpu_context); \
> } while (0)
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2015-07-30 5:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 19:08 [RFC][PATCH 0/7] sched: Remove finish_arch_switch() Peter Zijlstra
2015-07-29 19:08 ` [RFC][PATCH 1/7] arm: Remove finish_arch_switch Peter Zijlstra
2015-08-04 7:39 ` Ingo Molnar
2015-08-04 8:26 ` Russell King - ARM Linux
2015-08-04 8:32 ` Will Deacon
2015-07-29 19:08 ` [RFC][PATCH 2/7] MIPS: Get rid of finish_arch_switch() Peter Zijlstra
2015-07-29 19:08 ` [RFC][PATCH 3/7] avr32: Remove finish_arch_switch() Peter Zijlstra
2015-07-30 5:40 ` Hans-Christian Egtvedt [this message]
2015-07-29 19:08 ` [RFC][PATCH 4/7] score: " Peter Zijlstra
2015-07-29 19:08 ` [RFC][PATCH 5/7] sh: Fold finish_arch_switch() into switch_to() Peter Zijlstra
2015-07-29 19:08 ` [RFC][PATCH 6/7] Remove finish_arch_switch Peter Zijlstra
2015-07-29 19:08 ` [RFC][PATCH 7/7] sched: Remove finish_arch_switch() Peter Zijlstra
2015-07-30 9:50 ` [RFC][PATCH 0/7] " Peter Zijlstra
2015-07-31 8:51 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730054007.GA25446@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=cmetcalf@ezchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michael@amarulasolutions.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox