From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755369AbbG3Jka (ORCPT ); Thu, 30 Jul 2015 05:40:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59245 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751527AbbG3Jk2 (ORCPT ); Thu, 30 Jul 2015 05:40:28 -0400 Date: Thu, 30 Jul 2015 11:40:25 +0200 From: Thomas Petazzoni To: Alexandre Belloni Cc: Nicolas Ferre , Boris Brezillon , linux-pm@vger.kernel.org, Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, Sebastian Reichel , Maxime Ripard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 16/20] power/reset: at91-reset: remove useless at91_reset_platform_probe() Message-ID: <20150730114025.3eed9c1d@free-electrons.com> In-Reply-To: <1438215726-27452-17-git-send-email-alexandre.belloni@free-electrons.com> References: <1438215726-27452-1-git-send-email-alexandre.belloni@free-electrons.com> <1438215726-27452-17-git-send-email-alexandre.belloni@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Alexandre Belloni, On Thu, 30 Jul 2015 02:22:02 +0200, Alexandre Belloni wrote: > static int at91_reset_probe(struct platform_device *pdev) > { > int ret; > > - if (pdev->dev.of_node) > - ret = at91_reset_of_probe(pdev); > - else > - ret = at91_reset_platform_probe(pdev); > > + ret = at91_reset_of_probe(pdev); Maybe it no longer makes sense to have separate at91_reset_probe() and at91_reset_of_probe() functions then. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com