From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbbG3Lpw (ORCPT ); Thu, 30 Jul 2015 07:45:52 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:35570 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbbG3Lpu (ORCPT ); Thu, 30 Jul 2015 07:45:50 -0400 Date: Thu, 30 Jul 2015 12:45:45 +0100 From: Lee Jones To: Paul Bolle Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, jassisinghbrar@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP Message-ID: <20150730114545.GG14642@x1> References: <1437990272-23111-1-git-send-email-lee.jones@linaro.org> <1437990272-23111-4-git-send-email-lee.jones@linaro.org> <1438121215.30903.27.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1438121215.30903.27.camel@tiscali.nl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2015, Paul Bolle wrote: > On ma, 2015-07-27 at 10:44 +0100, Lee Jones wrote: > > --- /dev/null > > +++ b/drivers/mailbox/mailbox-sti.c > > > +static int sti_mbox_probe(struct platform_device *pdev) > > +{ > > + [...] > > + > > + match = of_match_device(sti_mailbox_match, &pdev->dev); > > + if (!match) { > > + dev_err(&pdev->dev, "No configuration found\n"); > > + return -ENODEV; > > + } > > + pdev->dev.platform_data = (struct sti_mbox_pdata *) match->data; > > + > > + [...] > > +} > > > +static struct platform_driver sti_mbox_driver = { > > + .probe = sti_mbox_probe, > > + .remove = sti_mbox_remove, > > + .driver = { > > + .name = "sti-mailbox", > > + .of_match_table = sti_mailbox_match, > > + }, > > +}; > > +module_platform_driver(sti_mbox_driver); > > > +MODULE_ALIAS("platform:mailbox-sti"); > > It seems this alias is only useful if there's a corresponding struct > platform_device with a "mailbox-sti" .name. I couldn't spot that > platform_device. > > Besides, if I read sti_max_probe() correctly, without OF support loading > this module won't accomplish much. So what would another way of > autoloading this module buy you? I think this line can be safely removed. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog