From: Matt Fleming <matt@codeblueprint.co.uk>
To: joeyli <jlee@suse.com>
Cc: Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
"Lee, Chun-Yi" <joeyli.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address
Date: Thu, 30 Jul 2015 14:17:23 +0100 [thread overview]
Message-ID: <20150730131723.GG2725@codeblueprint.co.uk> (raw)
In-Reply-To: <20150730123116.GL15651@linux-rxt1.site>
On Thu, 30 Jul, at 08:31:16PM, joeyli wrote:
>
> I think hibernate overwrite it.
We absolutely must get a more detailed answer before going any further.
Simply put, if we're remapping the EFI regions into the virtual address
space and calling SetVirtualAddressMap() on hibernate resume there is no
reason that anyone should be using the old mappings.
And since you've demonstrated that we *are* using the old mappings,
we've likely got a bug somewhere that we need to get a handle on before
we paper over the issue.
Where exactly is the old mapping address being used? Is it that
efi.systab->runtime->get_variable is incorrect? If you could paste the
disassembled output where the page fault occurs, that would be helpful.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-07-30 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 4:32 [PATCH] x86_64/efi: Mapping Boot and Runtime EFI memory regions to different starting virtual address Lee, Chun-Yi
2015-07-30 7:53 ` H. Peter Anvin
2015-07-30 8:03 ` Borislav Petkov
2015-07-30 10:11 ` Matt Fleming
2015-07-30 11:09 ` joeyli
2015-07-30 11:18 ` joeyli
2015-07-30 12:09 ` Matt Fleming
2015-07-30 12:31 ` joeyli
2015-07-30 13:17 ` Matt Fleming [this message]
2015-07-30 13:39 ` joeyli
2015-07-30 14:05 ` Matt Fleming
2015-07-30 14:16 ` joeyli
2015-08-19 16:31 ` Matt Fleming
2015-08-20 1:05 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730131723.GG2725@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jlee@suse.com \
--cc=joeyli.kernel@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox