public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Cavin, Courtney" <Courtney.Cavin@sonymobile.com>
Subject: Re: [PATCH 3/4] power: Add Qualcomm SMBB driver
Date: Thu, 30 Jul 2015 10:17:05 -0700	[thread overview]
Message-ID: <20150730171705.GF6519@usrtlx11787.corpusers.net> (raw)
In-Reply-To: <20150727140622.GB12993@earth>

On Mon 27 Jul 07:06 PDT 2015, Sebastian Reichel wrote:

> Hi,
> 
> On Sat, Jul 25, 2015 at 06:04:14PM -0700, Bjorn Andersson wrote:
> > On Sat 25 Jul 08:42 PDT 2015, Sebastian Reichel wrote:
> > >  * battery-charge-control-limit
> > > 
> > > It's unclear, what this property is used for. Is the limit only
> > > for "normal" charging or also for fast charging?
> > > 
> > 
> > This is described as the current limit during fast charging. However,
> > "fast charging" is the normal state.
> > 
> > I think the most consistent (regards documentation and other properties)
> > would be:
> > 
> >  qcom,fast-charge-current-limit

I spoke with Courtney about this and he pointed out that it really is
the limit of the current flowing into the battery, hence his original
naming.

> 
> So what's the difference to "fast-charge-safe-current"?
> 

The "safe" values are write-once values that should be set once during
boot to protect the hardware. The fast-charge-current-limit can be
modified in runtime by e.g. userspace or a thermal mitigation solution -
but will never be allowed to go above the safe limit.

Regards,
Bjorn

  reply	other threads:[~2015-07-30 17:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 21:13 [PATCH 0/4] Qualcomm Switch-Mode Battery Charger and Boost Bjorn Andersson
2015-06-18 21:13 ` [PATCH 1/4] spmi: pmic-arb: add irq_get_irqchip_state implementation Bjorn Andersson
2015-07-27  5:34   ` Andy Gross
2015-06-18 21:13 ` [PATCH 2/4] dt-binding: power: Add Qualcomm SMBB binding Bjorn Andersson
2015-06-18 21:13 ` [PATCH 3/4] power: Add Qualcomm SMBB driver Bjorn Andersson
2015-06-19 17:01   ` Paul Bolle
2015-06-22  5:06     ` Bjorn Andersson
2015-07-25 15:42   ` Sebastian Reichel
2015-07-26  1:04     ` Bjorn Andersson
2015-07-27 14:06       ` Sebastian Reichel
2015-07-30 17:17         ` Bjorn Andersson [this message]
2015-06-18 21:13 ` [PATCH 4/4] ARM: dts: qcom-pm8941: Add charger node Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730171705.GF6519@usrtlx11787.corpusers.net \
    --to=bjorn.andersson@sonymobile.com \
    --cc=Courtney.Cavin@sonymobile.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox