Re: [PATCH V3 12/16] PM / OPP: add dev_pm_opp_is_turbo() helper

Stephen Boyd
2015-07-31T06:10:28Z

On 07/29, Viresh Kumar wrote:
> +bool dev_pm_opp_is_turbo(struct dev_pm_opp *opp)
> +{
> + struct dev_pm_opp *tmp_opp;
> +
> + opp_rcu_lockdep_assert();
> +
> + tmp_opp = rcu_dereference(opp);
> + if (unlikely(IS_ERR_OR_NULL(tmp_opp)) || !tmp_opp->available) {

IS_ERR_OR_NULL already has unlikely inside it on the error
pointer path so it seems redundant here.

Otherwise

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project