The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	kbuild test robot <fengguang.wu@intel.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/CORTINA
	SYSTEMS GEMINI ARM ARCHITECTURE),
	rtc-linux@googlegroups.com (open list:REAL TIME CLOCK (RTC)
	SUBSYSTEM)
Subject: [PATCH] drivers: rtc: fix ptr_ret.cocci warnings
Date: Fri, 31 Jul 2015 15:01:04 +0530	[thread overview]
Message-ID: <20150731091703.GA140615@lkp-ib03> (raw)
In-Reply-To: <cdfa3fb76901fe1c4a5756e7e64cb3370cf6317a.1438331416.git.viresh.kumar@linaro.org>

From: kbuild test robot <fengguang.wu@intel.com>

drivers/rtc/rtc-gemini.c:151:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Got a cleanup patch from Fengguang, maybe we can apply this too.

 rtc-gemini.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/rtc/rtc-gemini.c
+++ b/drivers/rtc/rtc-gemini.c
@@ -148,10 +148,7 @@ static int gemini_rtc_probe(struct platf
 
 	rtc->rtc_dev = rtc_device_register(pdev->name, dev,
 					   &gemini_rtc_ops, THIS_MODULE);
-	if (IS_ERR(rtc->rtc_dev))
-		return PTR_ERR(rtc->rtc_dev);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(rtc->rtc_dev);
 }
 
 static int gemini_rtc_remove(struct platform_device *pdev)


  reply	other threads:[~2015-07-31  9:31 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31  8:38 [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31  8:38 ` [PATCH 01/15] err.h: add (missing) unlikely() to IS_ERR_OR_NULL() Viresh Kumar
2015-07-31  8:38 ` [PATCH 02/15] PM / OPP: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31  8:38 ` [PATCH 03/15] drivers: devfreq: " Viresh Kumar
2015-07-31  8:38 ` [PATCH 04/15] drivers: gpu: " Viresh Kumar
2015-07-31 15:53   ` Sinclair Yeh
2015-08-03  8:01     ` Daniel Vetter
2015-07-31  8:38 ` [PATCH 05/15] drivers: input: " Viresh Kumar
2015-07-31 16:58   ` Dmitry Torokhov
2015-08-01 11:22     ` Viresh Kumar
2015-08-01 11:44       ` Pali Rohár
2015-08-02 15:43         ` Pavel Machek
2015-08-02 15:59           ` Pali Rohár
2015-07-31  8:38 ` [PATCH 06/15] drivers: md: " Viresh Kumar
2015-07-31  8:38 ` [PATCH 07/15] drivers: misc: " Viresh Kumar
2015-07-31  8:38 ` [PATCH 08/15] drivers: net: " Viresh Kumar
2015-07-31 15:04   ` Murali Karicheri
2015-07-31 15:39     ` David Laight
2015-07-31 16:20     ` Viresh Kumar
2015-08-03 15:52       ` Murali Karicheri
2015-07-31  8:38 ` [PATCH 09/15] drivers: rtc: " Viresh Kumar
2015-07-31  9:31   ` Viresh Kumar [this message]
2015-08-11 15:54     ` [PATCH] drivers: rtc: fix ptr_ret.cocci warnings Alexandre Belloni
2015-07-31 10:53   ` [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03  4:32     ` Hans Ulli Kroll
2015-08-11 15:54     ` Alexandre Belloni
2015-07-31  8:38 ` [PATCH 10/15] drivers: staging: Drop unlikely " Viresh Kumar
2015-07-31  8:38 ` [PATCH 11/15] drivers: target: " Viresh Kumar
2015-08-03  5:45   ` Nicholas A. Bellinger
2015-07-31  8:38 ` [PATCH 12/15] fs: " Viresh Kumar
2015-07-31  9:20   ` David Howells
2015-07-31  8:38 ` [PATCH 13/15] blk-cgroup: " Viresh Kumar
2015-07-31 11:59   ` Tejun Heo
2015-07-31  8:38 ` [PATCH 14/15] mm: " Viresh Kumar
2015-07-31  8:56   ` Kirill A. Shutemov
2015-07-31  9:32     ` yalin wang
2015-07-31  9:34       ` Viresh Kumar
2015-07-31 10:28         ` Joe Perches
2015-07-31 11:06           ` Viresh Kumar
2015-07-31 18:00             ` Joe Perches
2015-08-01 11:18               ` Viresh Kumar
2015-07-31  8:38 ` [PATCH 15/15] net: " Viresh Kumar
2015-07-31  9:41 ` [PATCH 00/15] trivial: " Vlastimil Babka
2015-07-31  9:49   ` Viresh Kumar
2015-07-31 10:23   ` Kirill A. Shutemov
2015-07-31 11:02     ` [PATCH] staging: lustre: drop redundant check Viresh Kumar
2015-07-31 11:04     ` [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 21:38     ` Steven Rostedt
2015-08-04  2:19       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150731091703.GA140615@lkp-ib03 \
    --to=viresh.kumar@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=ulli.kroll@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox