Re: [RFC PATCH 01/16] PM / hibernate: define HMAC algorithm and digest size of swsusp

[joeyli <jlee@suse.com>]

On Tue, Jul 28, 2015 at 02:01:56PM +0200, Pavel Machek wrote:
> On Thu 2015-07-16 22:25:15, Lee, Chun-Yi wrote:
> > Using HMAC-SHA1 to be the HMAC algorithm of signing hibernate
> > snapshot image. The digest size of HMAC-SHA1 is 160 bits (20 bytes),
> > this size will be also applied to the length of HMAC key.
> > 
> > In addition, add HIBERNATE_VERIFICATION kernel config.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > ---
> >  include/linux/suspend.h |  5 +++++
> >  kernel/power/Kconfig    | 13 +++++++++++++
> >  kernel/power/power.h    |  1 +
> >  3 files changed, 19 insertions(+)
> > 
> > diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> > index 5efe743..6cd2a48 100644
> > --- a/include/linux/suspend.h
> > +++ b/include/linux/suspend.h
> > @@ -327,6 +327,11 @@ struct platform_hibernation_ops {
> >  };
> >  
> >  #ifdef CONFIG_HIBERNATION
> > +
> > +/* HMAC Algorithm of Hibernate Signature */
> > +#define SWSUSP_HMAC		"hmac(sha1)"
> > +#define SWSUSP_DIGEST_SIZE	20
> 
> I'd replace SWSUSP with HIBERNATION here, and pretty much everywhere.
>

SWSUSP is shorter than HIBERNATION, and there have some codes in hibernate
are also using swsusp. I still want to use it.


Thanks a lot!
Joey Lee