From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947613AbbGaV1a (ORCPT ); Fri, 31 Jul 2015 17:27:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:56127 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1946466AbbGaV10 (ORCPT ); Fri, 31 Jul 2015 17:27:26 -0400 Date: Fri, 31 Jul 2015 23:27:24 +0200 From: Alexandre Belloni To: Stephen Boyd Cc: Nicolas Ferre , Boris Brezillon , Maxime Ripard , Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH 23/23] clk: at91: Revert "keep slow clk enabled to prevent system hang" Message-ID: <20150731212724.GN27985@piout.net> References: <1438335599-3301-1-git-send-email-alexandre.belloni@free-electrons.com> <1438335599-3301-24-git-send-email-alexandre.belloni@free-electrons.com> <55BBC5CC.80406@codeaurora.org> <20150731210905.GM27985@piout.net> <55BBE47F.3010307@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55BBE47F.3010307@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/2015 at 14:11:27 -0700, Stephen Boyd wrote : > On 07/31/2015 02:09 PM, Alexandre Belloni wrote: > >On 31/07/2015 at 12:00:28 -0700, Stephen Boyd wrote : > >>On 07/31/2015 02:39 AM, Alexandre Belloni wrote: > >>>- clk_prepare_enable(slow_clk); > >>>- > >>>- return 0; > >>>-} > >>>-arch_initcall(of_at91_clk_slow_retain); > >>Can you drop the include of clk.h in this file too? > >> > >Sure! I will do that in v3. However, I'll wait for some feedback from > >the other maintainers before sending again. > > > > Cool. Also, are you going to take this through arm-soc? If so, feel free to > add my ack. > Actually, clk.h has never been included in that file. I was thinking you could take it once the other patch made it in each subsystem. It is not urgent, it can probably skip one or two cycles. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com