From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: yalin wang <yalin.wang2010@gmail.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
linaro-kernel@lists.linaro.org,
open list <linux-kernel@vger.kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
David Rientjes <rientjes@google.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 14/15] mm: Drop unlikely before IS_ERR(_OR_NULL)
Date: Sat, 1 Aug 2015 16:48:21 +0530 [thread overview]
Message-ID: <20150801111821.GJ899@linux> (raw)
In-Reply-To: <1438365622.19675.97.camel@perches.com>
On 31-07-15, 11:00, Joe Perches wrote:
> On Fri, 2015-07-31 at 16:36 +0530, Viresh Kumar wrote:
> > On 31-07-15, 03:28, Joe Perches wrote:
> > > If it's all fixed, then it's unlikely to be needed in checkpatch.
> >
> > I thought checkpatch is more about not committing new mistakes, rather than
> > finding them in old code.
>
> True, but checkpatch is more about style than substance.
>
> There are a lot of things that _could_ be added to the script
> but don't have to be because of relative rarity.
>
> The unanswered fundamental though is whether the unlikely use
> in #define IS_ERR_VALUE is useful.
>
> include/linux/err.h:21:#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
>
> How often does using unlikely here make the code smaller/faster
> with more recent compilers than gcc 3.4? Or even using gcc 3.4.
No idea :)
--
viresh
next prev parent reply other threads:[~2015-08-01 11:18 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 8:38 [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 8:38 ` [PATCH 01/15] err.h: add (missing) unlikely() to IS_ERR_OR_NULL() Viresh Kumar
2015-07-31 8:38 ` [PATCH 02/15] PM / OPP: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-07-31 8:38 ` [PATCH 03/15] drivers: devfreq: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 04/15] drivers: gpu: " Viresh Kumar
2015-07-31 15:53 ` Sinclair Yeh
2015-08-03 8:01 ` Daniel Vetter
2015-07-31 8:38 ` [PATCH 05/15] drivers: input: " Viresh Kumar
2015-07-31 16:58 ` Dmitry Torokhov
2015-08-01 11:22 ` Viresh Kumar
2015-08-01 11:44 ` Pali Rohár
2015-08-02 15:43 ` Pavel Machek
2015-08-02 15:59 ` Pali Rohár
2015-07-31 8:38 ` [PATCH 06/15] drivers: md: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 07/15] drivers: misc: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 08/15] drivers: net: " Viresh Kumar
2015-07-31 15:04 ` Murali Karicheri
2015-07-31 15:39 ` David Laight
2015-07-31 16:20 ` Viresh Kumar
2015-08-03 15:52 ` Murali Karicheri
2015-07-31 8:38 ` [PATCH 09/15] drivers: rtc: " Viresh Kumar
2015-07-31 9:31 ` [PATCH] drivers: rtc: fix ptr_ret.cocci warnings Viresh Kumar
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 10:53 ` [PATCH 9/15 V2] drivers: rtc: Drop (un)likely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 4:32 ` Hans Ulli Kroll
2015-08-11 15:54 ` Alexandre Belloni
2015-07-31 8:38 ` [PATCH 10/15] drivers: staging: Drop unlikely " Viresh Kumar
2015-07-31 8:38 ` [PATCH 11/15] drivers: target: " Viresh Kumar
2015-08-03 5:45 ` Nicholas A. Bellinger
2015-07-31 8:38 ` [PATCH 12/15] fs: " Viresh Kumar
2015-07-31 8:38 ` [PATCH 13/15] blk-cgroup: " Viresh Kumar
2015-07-31 11:59 ` Tejun Heo
2015-07-31 8:38 ` [PATCH 14/15] mm: " Viresh Kumar
2015-07-31 8:56 ` Kirill A. Shutemov
2015-07-31 9:32 ` yalin wang
2015-07-31 9:34 ` Viresh Kumar
2015-07-31 10:28 ` Joe Perches
2015-07-31 11:06 ` Viresh Kumar
2015-07-31 18:00 ` Joe Perches
2015-08-01 11:18 ` Viresh Kumar [this message]
2015-07-31 8:38 ` [PATCH 15/15] net: " Viresh Kumar
2015-07-31 9:20 ` [PATCH 12/15] fs: " David Howells
2015-07-31 9:41 ` [PATCH 00/15] trivial: " Vlastimil Babka
2015-07-31 9:49 ` Viresh Kumar
2015-07-31 10:23 ` Kirill A. Shutemov
2015-07-31 11:02 ` [PATCH] staging: lustre: drop redundant check Viresh Kumar
2015-07-31 11:04 ` [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar
2015-08-03 21:38 ` Steven Rostedt
2015-08-04 2:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150801111821.GJ899@linux \
--to=viresh.kumar@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ebru.akagunduz@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=joe@perches.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).