public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Irina Tirdea <irina.tirdea@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
	Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH v3 2/8] eeprom: at24: use i2c_smbus_read_i2c_block_data_or_emulated
Date: Sat, 1 Aug 2015 21:57:56 +0200	[thread overview]
Message-ID: <20150801195756.GB1590@katana> (raw)
In-Reply-To: <1435916017-12859-3-git-send-email-irina.tirdea@intel.com>

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

> +		if (at24->use_smbus) {
> +			status =
> +			    i2c_smbus_read_i2c_block_data_or_emulated(client,
> +								      offset,
> +								      count,
> +								      buf);

Please ignore checkpatch warnings for this one and find a nice readable
way to squeeze that into two lines.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-08-01 19:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-03  9:33 [PATCH v3 0/8] Add support for best effort block read emulation Irina Tirdea
2015-07-03  9:33 ` [PATCH v3 1/8] i2c: core: " Irina Tirdea
2015-07-05 11:58   ` Jonathan Cameron
2015-07-10 17:14     ` Tirdea, Irina
2015-07-11 17:40       ` Jonathan Cameron
2015-08-01 19:53       ` Wolfram Sang
2015-08-04 13:51         ` Tirdea, Irina
2015-07-03  9:33 ` [PATCH v3 2/8] eeprom: at24: use i2c_smbus_read_i2c_block_data_or_emulated Irina Tirdea
2015-08-01 19:57   ` Wolfram Sang [this message]
2015-08-04 13:52     ` Tirdea, Irina
2015-07-03  9:33 ` [PATCH v3 3/8] iio: accel: bmc150: use available_scan_masks Irina Tirdea
2015-07-05 12:10   ` Jonathan Cameron
2015-07-03  9:33 ` [PATCH v3 4/8] iio: accel: bmc150: optimize i2c transfers in trigger handler Irina Tirdea
2015-07-05 12:06   ` Jonathan Cameron
2015-07-03  9:33 ` [PATCH v3 5/8] iio: gyro: bmg160: use available_scan_masks Irina Tirdea
2015-07-03  9:33 ` [PATCH v3 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler Irina Tirdea
2015-07-05 12:08   ` Jonathan Cameron
2015-07-10 17:31     ` Tirdea, Irina
2015-07-10 17:46       ` Pandruvada, Srinivas
2015-07-03  9:33 ` [PATCH v3 7/8] iio: accel: kxcjk-1013: use available_scan_masks Irina Tirdea
2015-07-05 12:10   ` Jonathan Cameron
2015-07-03  9:33 ` [PATCH v3 8/8] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler Irina Tirdea
2015-07-05 12:11   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150801195756.GB1590@katana \
    --to=wsa@the-dreams.de \
    --cc=irina.tirdea@intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=srinivas.pandruvada@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox