Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)

Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)

[MyungJoo Ham]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1041 bytes --]

> On 03-08-15, 05:10, MyungJoo Ham wrote:
> > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> > > is no need to do that again from its callers. Drop it.
> > > 
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > @ from include/linux/err.h
> > #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> > ...
> > static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> > {
> > 	return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> > }
> > 
> > "!ptr" appears not covered with IS_ERR_OR_NULL.
> > (only the IS_ERR part seems covered)
> 
> Right, the first patch of the series has fixed that.
> 
> http://permalink.gmane.org/gmane.linux.kernel/2009151

Ah.. ok, then,


Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>


please let me know when the series is ready to go.


Cheers,
MyungJoo

> 
> -- 
> viresh
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: Re: [PATCH 03/15] drivers: devfreq: Drop unlikely before IS_ERR(_OR_NULL)

[Viresh Kumar]

On 03-08-15, 05:50, MyungJoo Ham wrote:
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> 
> 
> please let me know when the series is ready to go.

It wouldn't harm even if you apply it without 1/15. So, just go on and
apply :)

-- 
viresh