From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752347AbbHCHQ1 (ORCPT ); Mon, 3 Aug 2015 03:16:27 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50595 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbbHCHQZ (ORCPT ); Mon, 3 Aug 2015 03:16:25 -0400 Date: Mon, 3 Aug 2015 10:16:04 +0300 From: Dan Carpenter To: "Wang, Biao" Cc: "gregkh@linuxfoundation.org" , "arve@android.com" , "riandrews@android.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Zhang, Di" , "Li, Fei" , "joe@perches.com" Subject: Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue Message-ID: <20150803071604.GT5096@mwanda> References: <09CB0B4607EB8F4DB7E0BE3B06BFBD051DA2E849@SHSMSX101.ccr.corp.intel.com> <20150803061556.GS5096@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803061556.GS5096@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 03, 2015 at 09:15:56AM +0300, Dan Carpenter wrote: > > Reviewed-by: Dan Carpenter > > I don't really feel comfortable saying I reviewed this code. I just > commented on a few process issues. I don't know the subsystem well > enough to give it a seal of approval. > Biao was asking off list, how to fix this. I guess just leave it. I more care about going forward that we don't start doing this all the time. I recently added a reviewed-by tag for someone. He told me off list that the patch "looks OK". He was the subsystem expert and we were patching his code so it was his responsibility to review the fix. If the patch breaks everyone's system then he's absolutely the guy that I want people to blame. :) regards, dan carpenter