[PATCH v2] regulator: axp20x: Add module alias

[PATCH v2] regulator: axp20x: Add module alias

[Ian Campbell]

This allows the module to be autoloaded.

Together with 07949bf9c63c ("cpufreq: dt: allow driver to boot
automatically") this is sufficient to allow a modular kernel (such
as Debian's) to enable cpufreq on a Cubietruck.

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-sunxi@googlegroups.com
---
v2: Submit properly.
---
 drivers/regulator/axp20x-regulator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index e4331f5..2c82131 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -264,3 +264,4 @@ module_platform_driver(axp20x_regulator_driver);
 MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("Carlo Caione <carlo@caione.org>");
 MODULE_DESCRIPTION("Regulator Driver for AXP20X PMIC");
+MODULE_ALIAS("platform:axp20x-regulator");
-- 
2.1.4

Re: [PATCH v2] regulator: axp20x: Add module alias

[Paul Bolle]

On za, 2015-08-01 at 18:13 +0100, Ian Campbell wrote:
> This allows the module to be autoloaded.
> 
> Together with 07949bf9c63c ("cpufreq: dt: allow driver to boot
> automatically") this is sufficient to allow a modular kernel (such
> as Debian's) to enable cpufreq on a Cubietruck.

> --- a/drivers/regulator/axp20x-regulator.c
> +++ b/drivers/regulator/axp20x-regulator.c

> +MODULE_ALIAS("platform:axp20x-regulator");

Should this eventually go into stable?

The regulator driver for AXP20x was added in v3.16, so this patch could
currently be relevant for the v3.18.y and v4.1.y trees. (In those trees
the corresponding platform devices, which are needed to make this alias
useful, appear to be present.)

Same question for 07949bf9c63c ("cpufreq: dt: allow driver to boot
automatically"), I guess.


Paul Bolle

Re: [PATCH v2] regulator: axp20x: Add module alias

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]

On Mon, Aug 03, 2015 at 10:51:49AM +0200, Paul Bolle wrote:
> On za, 2015-08-01 at 18:13 +0100, Ian Campbell wrote:
> > This allows the module to be autoloaded.
> > 
> > Together with 07949bf9c63c ("cpufreq: dt: allow driver to boot
> > automatically") this is sufficient to allow a modular kernel (such
> > as Debian's) to enable cpufreq on a Cubietruck.
> 
> > --- a/drivers/regulator/axp20x-regulator.c
> > +++ b/drivers/regulator/axp20x-regulator.c
> 
> > +MODULE_ALIAS("platform:axp20x-regulator");
> 
> Should this eventually go into stable?
> 
> The regulator driver for AXP20x was added in v3.16, so this patch could
> currently be relevant for the v3.18.y and v4.1.y trees. (In those trees
> the corresponding platform devices, which are needed to make this alias
> useful, appear to be present.)
> 
> Same question for 07949bf9c63c ("cpufreq: dt: allow driver to boot
> automatically"), I guess.

Yes, it probably should.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2] regulator: axp20x: Add module alias

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

On Sat, Aug 01, 2015 at 06:13:25PM +0100, Ian Campbell wrote:
> This allows the module to be autoloaded.
> 
> Together with 07949bf9c63c ("cpufreq: dt: allow driver to boot
> automatically") this is sufficient to allow a modular kernel (such
> as Debian's) to enable cpufreq on a Cubietruck.

Please don't bury submissions in old mail threads.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]