Re: [PATCHv3 3/6] Staging: most: Fix "missing static keyword" warnings

[Christian Gromm <christian.gromm@microchip.com>]

On Mon, 3 Aug 2015 09:40:24 +0200
Adrian Remonda <adrianremonda@gmail.com> wrote:

> This is a patch to the most/hdm-usb/hdm_usb.c file. It
> makes several local functions and structures static to prevent global visibility.
> 
> Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
> index a4a3e266b3ef..f4de88403177 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -280,7 +280,7 @@ static unsigned int get_stream_frame_size(struct most_channel_config *cfg)
>   *
>   * Returns 0 on success or error code otherwise.
>   */
> -int hdm_poison_channel(struct most_interface *iface, int channel)
> +static int hdm_poison_channel(struct most_interface *iface, int channel)
>  {
>  	struct most_dev *mdev;
>  
> @@ -318,7 +318,7 @@ int hdm_poison_channel(struct most_interface *iface, int channel)
>   * This inserts the INIC hardware specific padding bytes into a streaming
>   * channel's buffer
>   */
> -int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
> +static int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
>  {
>  	struct most_channel_config *conf = &mdev->conf[channel];
>  	unsigned int j, num_frames, frame_size;
> @@ -354,7 +354,7 @@ int hdm_add_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
>   * This takes the INIC hardware specific padding bytes off a streaming
>   * channel's buffer.
>   */
> -int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
> +static int hdm_remove_padding(struct most_dev *mdev, int channel, struct mbo *mbo)
>  {
>  	unsigned int j, num_frames, frame_size;
>  	struct most_channel_config *const conf = &mdev->conf[channel];
> @@ -629,7 +629,7 @@ static void hdm_read_completion(struct urb *urb)
>   *
>   * Context: Could in _some_ cases be interrupt!
>   */
> -int hdm_enqueue(struct most_interface *iface, int channel, struct mbo *mbo)
> +static int hdm_enqueue(struct most_interface *iface, int channel, struct mbo *mbo)
>  {
>  	struct most_dev *mdev;
>  	struct buf_anchor *anchor;
> @@ -730,7 +730,7 @@ _error:
>   * @channel: channel ID
>   * @conf: structure that holds the configuration information
>   */
> -int hdm_configure_channel(struct most_interface *iface, int channel,
> +static int hdm_configure_channel(struct most_interface *iface, int channel,
>  			  struct most_channel_config *conf)
			  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Please keep alignment with parameter list of this function.

Thanks,
Chris

>  {
>  	unsigned int num_frames;
> @@ -808,7 +808,7 @@ exit:
>   * This triggers the USB vendor requests to read the hardware address and
>   * the current link status of the attached device.
>   */
> -int hdm_update_netinfo(struct most_dev *mdev)
> +static int hdm_update_netinfo(struct most_dev *mdev)
>  {
>  	int i;
>  	u16 link;
> @@ -856,7 +856,7 @@ int hdm_update_netinfo(struct most_dev *mdev)
>   * polls for the NI state of the INIC every 2 seconds.
>   *
>   */
> -void hdm_request_netinfo(struct most_interface *iface, int channel)
> +static void hdm_request_netinfo(struct most_interface *iface, int channel)
>  {
>  	struct most_dev *mdev;
>