From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbbHCOQ3 (ORCPT ); Mon, 3 Aug 2015 10:16:29 -0400 Received: from 8bytes.org ([81.169.241.247]:53723 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbHCOQ2 (ORCPT ); Mon, 3 Aug 2015 10:16:28 -0400 Date: Mon, 3 Aug 2015 16:16:26 +0200 From: Joerg Roedel To: Kees Cook Cc: linux-kernel@vger.kernel.org, David Woodhouse , iommu@lists.linux-foundation.org Subject: Re: [PATCH] iommu: avoid format string leaks into iommu_device_create Message-ID: <20150803141625.GB20968@8bytes.org> References: <20150724232757.GA14747@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150724232757.GA14747@www.outflux.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 04:27:57PM -0700, Kees Cook wrote: > This makes sure it won't be possible to accidentally leak format > strings into iommu device names. Current name allocations are safe, > but this makes the "%s" explicit. > > Signed-off-by: Kees Cook > --- > drivers/iommu/dmar.c | 2 +- > drivers/iommu/intel-iommu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks.