From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932150AbbHCQS7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 12:18:59 -0400
Received: from eddie.linux-mips.org ([148.251.95.138]:41917 "EHLO
	cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932125AbbHCQS6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 12:18:58 -0400
Date: Mon, 3 Aug 2015 18:18:45 +0200
From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, Rusty Russell <rusty@rustcorp.com.au>,
        Joshua Kinard <kumba@gentoo.org>,
        Andrew Bresticker <abrestic@chromium.org>,
        Huacai Chen <chenhc@lemote.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Kevin Cernekee <cernekee@gmail.com>, linux-kernel@vger.kernel.org,
        "Maciej W. Rozycki" <macro@codesourcery.com>,
        Markos Chandras <markos.chandras@imgtec.com>,
        Alex Smith <alex.smith@imgtec.com>
Subject: Re: [PATCH] MIPS: c-r4k: remove cpu_foreign_map
Message-ID: <20150803161845.GG2843@linux-mips.org>
References: <1438617288-25261-1-git-send-email-paul.burton@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438617288-25261-1-git-send-email-paul.burton@imgtec.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 03, 2015 at 08:54:47AM -0700, Paul Burton wrote:

> Commit cccf34e9411c ("MIPS: c-r4k: Fix cache flushing for MT cores") did
> 2 things:
> 
>   - Introduced cpu_foreign_map to call cache maintenance functions on
>     only a single CPU within each core in the system.
> 
>   - Stopped calling cache maintenance functions on non-local CPUs for
>     systems which include a MIPS Coherence Manager.
> 
> Thus the introduction of cpu_foreign_map has no effect on any systems
> with a CM, since the IPIs will be avoided entirely. Thus it can only
> possibly affect other systems which have multiple logical CPUs per core,
> which appears to only be netlogic. I'm pretty certain this wasn't the
> intent, am unsure whether avoiding such cache maintenance calls is
> correct for netlogic systems and believe the overhead of calculating
> cpu_foreign_map is thus unnecessary & this code is almost certainly
> untested.
> 
> This mostly reverts commit cccf34e9411c ("MIPS: c-r4k: Fix cache
> flushing for MT cores"), leaving only the change for systems with a CM.

BMIPS is another "hyperthreading-like" core.  Maybe Kevin or Florian
can comment if this patch is good for them?

  Ralf