From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754499AbbHCQwD (ORCPT ); Mon, 3 Aug 2015 12:52:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbbHCQwB (ORCPT ); Mon, 3 Aug 2015 12:52:01 -0400 Date: Mon, 3 Aug 2015 18:49:58 +0200 From: Oleg Nesterov To: kernel test robot Cc: lkp@01.org, LKML , "David S. Miller" Subject: Re: [lkp] [net] 1fbe4b46cac: WARNING: CPU: 0 PID: 2245 at kernel/sched/core.c:7376 __might_sleep+0x8b/0xa8() Message-ID: <20150803164958.GA17910@redhat.com> References: <871tfqqtuy.fsf@yhuang-dev.intel.com> <20150730212020.GA8185@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150730212020.GA8185@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/30, Oleg Nesterov wrote: > > Thanks! > > I am travelling, I'll send the trivial fix on Monday. > > Just in case, this is not a bug, we only need to shut up the warning and we > even have the special macro for that. I forgot its name, and I don't have the > kernel sources right now. Now that I can actually see the code, I think that we should simply remove __set_current_state(TASK_RUNNING) and set_current_state(TASK_INTERRUPTIBLE). But let me re-check this once again tomorrow, I simply can't understand why pktgen_thread_worker() does this. Unless I am totally confused they could be removed right after ef87979c273a2 "pktgen: better scheduler friendliness" which in particular changed the main loop to use wait_event(). Then later baac167b "pktgen: avoid expensive set_current_state() call in loop" changed the 1st __set_current_state() to set RUNNING, and moved the 2nd set_current_state(TASK_INTERRUPTIBLE) outside the main loop for absolutely no reason. Oleg.