From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755510AbbHCUYU (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 16:24:20 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:18844 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753061AbbHCUYS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 16:24:18 -0400
Date: Mon, 3 Aug 2015 23:23:47 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kris Borer <kborer@gmail.com>
Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, hdegoede@redhat.com,
        chasemetzger15@gmail.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: devio: remove assignment from if condition
Message-ID: <20150803202347.GX5096@mwanda>
References: <1438621706-3487-1-git-send-email-kborer@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438621706-3487-1-git-send-email-kborer@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 03, 2015 at 01:08:26PM -0400, Kris Borer wrote:
>  		else
> +		switch (ctl->ioctl_code) {

This else statement isn't indented.  It looks weird and it will cause
static checker warnings (hopefully).

Maybe leave that one out and send the rest.  Do complicated one in a
different patch.

regards,
dan carpenter