From: Greg KH <gregkh@linuxfoundation.org>
To: Jose Manuel Abuin Mosquera <abuinjm@gmail.com>
Cc: cascardo@linux.vnet.ibm.com, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] tty/serial: jsm: Added spaces in if sentences and around binary operators
Date: Mon, 3 Aug 2015 16:33:32 -0700 [thread overview]
Message-ID: <20150803233332.GA6205@kroah.com> (raw)
In-Reply-To: <1438241765-3094-1-git-send-email-abuinjm@gmail.com>
On Thu, Jul 30, 2015 at 09:36:05AM +0200, Jose Manuel Abuin Mosquera wrote:
> From: "Jose M. Abuin" <abuinjm@gmail.com>
>
> Added a blank line between variable declaration and code.
> Changed printk(KERN_INFO by pr_info( in some lines.
> Fixed space separations in if - else sentences.
> Added spaces between binary operators and variables.
> Variable assignation outside if in line 766.
A patch should only do one thing. You are doing multiple things here in
this patch so please break it out into multiple patches.
thanks,
greg k-h
prev parent reply other threads:[~2015-08-03 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 7:36 [PATCH 1/1] tty/serial: jsm: Added spaces in if sentences and around binary operators Jose Manuel Abuin Mosquera
2015-08-03 23:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803233332.GA6205@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abuinjm@gmail.com \
--cc=cascardo@linux.vnet.ibm.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox