From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755691AbbHCXde (ORCPT ); Mon, 3 Aug 2015 19:33:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46913 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754224AbbHCXdc (ORCPT ); Mon, 3 Aug 2015 19:33:32 -0400 Date: Mon, 3 Aug 2015 16:33:32 -0700 From: Greg KH To: Jose Manuel Abuin Mosquera Cc: cascardo@linux.vnet.ibm.com, jslaby@suse.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] tty/serial: jsm: Added spaces in if sentences and around binary operators Message-ID: <20150803233332.GA6205@kroah.com> References: <1438241765-3094-1-git-send-email-abuinjm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438241765-3094-1-git-send-email-abuinjm@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 30, 2015 at 09:36:05AM +0200, Jose Manuel Abuin Mosquera wrote: > From: "Jose M. Abuin" > > Added a blank line between variable declaration and code. > Changed printk(KERN_INFO by pr_info( in some lines. > Fixed space separations in if - else sentences. > Added spaces between binary operators and variables. > Variable assignation outside if in line 766. A patch should only do one thing. You are doing multiple things here in this patch so please break it out into multiple patches. thanks, greg k-h