From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933175AbbHDLAr (ORCPT ); Tue, 4 Aug 2015 07:00:47 -0400 Received: from down.free-electrons.com ([37.187.137.238]:58321 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932419AbbHDLAq (ORCPT ); Tue, 4 Aug 2015 07:00:46 -0400 Date: Tue, 4 Aug 2015 13:00:44 +0200 From: Alexandre Belloni To: Daniel Lezcano Cc: Nicolas Ferre , Boris Brezillon , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 19/20] clocksource: atmel-st: get and use slow clock Message-ID: <20150804110044.GK3486@piout.net> References: <1438215726-27452-1-git-send-email-alexandre.belloni@free-electrons.com> <1438215726-27452-20-git-send-email-alexandre.belloni@free-electrons.com> <55C09477.3080209@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C09477.3080209@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2015 at 12:31:19 +0200, Daniel Lezcano wrote : > On 07/30/2015 02:22 AM, Alexandre Belloni wrote: > >The current slow clock rate is hardcoded. Properly get the slow clock > >and use its rate. > > > >Signed-off-by: Alexandre Belloni > >--- > > [ ... ] > > >+struct clk *sclk; > > Do you need this variable global ? AFAICS, its scope is in the init > function, no ? > Indeed. > >+int timer_latch; > > static. > Yeah, this was changed in v2 (that I forgot to label as v2). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com