From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755987AbbHDO1y (ORCPT ); Tue, 4 Aug 2015 10:27:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46060 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755236AbbHDO1w (ORCPT ); Tue, 4 Aug 2015 10:27:52 -0400 Date: Tue, 4 Aug 2015 10:27:50 -0400 From: Don Zickus To: Michal Hocko Cc: Ulrich Obergfell , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, atomlin@redhat.com, jolsa@kernel.org, eranian@google.com, cmetcalf@ezchip.com, fweisbec@gmail.com Subject: Re: [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug() Message-ID: <20150804142750.GR42530@redhat.com> References: <1438433365-2979-1-git-send-email-uobergfe@redhat.com> <1438433365-2979-5-git-send-email-uobergfe@redhat.com> <20150804133129.GF28571@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150804133129.GF28571@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2015 at 03:31:30PM +0200, Michal Hocko wrote: > On Sat 01-08-15 14:49:25, Ulrich Obergfell wrote: > [...] > > @@ -3368,7 +3368,10 @@ static __init int fixup_ht_bug(void) > > return 0; > > } > > > > - watchdog_nmi_disable_all(); > > + if (watchdog_suspend() != 0) { > > + pr_info("failed to disable PMU erratum BJ122, BV98, HSD29 workaround\n"); > > + return 0; > > + } > > Is this really worth reporting to the log? What is an admin supposed to > do about it? I think it was more for developers to aid in debugging a strange behaviour of the performance counters. > > Ok, so kthread_park fails only when the kernel thread has already > exited. Can this ever happen during this call path? It might be overkill, but it is just a harmless informational failure message. Cheers, Don