From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"luto@kernel.org" <luto@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"eranian@google.com" <eranian@google.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D
Date: Tue, 4 Aug 2015 14:53:34 -0300 [thread overview]
Message-ID: <20150804175334.GD3126@kernel.org> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077018D186D@SHSMSX103.ccr.corp.intel.com>
Em Tue, Aug 04, 2015 at 05:07:40PM +0000, Liang, Kan escreveu:
> > Em Wed, Jul 29, 2015 at 12:43:22PM -0300, Arnaldo Carvalho de Melo
> > > I'll take a look at how interesting it would be to have a
> > > evsel->evlist, that if NULL means the evsel is freestanding, but when
> > > it is linked to an evlist, then it will be there. This way we wouldn't
> > > have to pass (evlist, evsel) when the main purpose of a function is
> > > about an evsel but we need information that is logically associated to
> > > all evsels in a list, i.e. that is in evsel->evlist.
> > There are no cases where a function receives (evsel, evlist) with that evlist
> > containing that evsel :-\
> > Perhaps this will be the first, i.e. rename perf_session_env to perf_env,
> > then store it in evlist->env, then when processing something where we
> > have a evsel or evlist we can access that env from:
> > evsel->evlist->env;
> > Will continue after lunch, trying to prototype what I just described.
> Hi Arnaldo,
> Have you got a chance to implement the prototype for evlist->env?
Not really, got sidetracked :-\
- Arnaldo
next prev parent reply other threads:[~2015-08-04 17:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 11:29 [PATCH V3 0/5] Freq/CPU%/CORE_BUSY% support kan.liang
2015-07-28 11:29 ` [PATCH V3 1/5] perf,tools: introduce generic FEAT for CPU attributes kan.liang
2015-07-29 12:31 ` Jiri Olsa
2015-07-28 11:29 ` [PATCH V3 2/5] perf,tools: read msr pmu type from header kan.liang
2015-07-28 11:29 ` [PATCH V3 3/5] perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D kan.liang
2015-07-29 12:52 ` Jiri Olsa
2015-07-29 15:12 ` Arnaldo Carvalho de Melo
2015-07-29 12:53 ` Jiri Olsa
2015-07-29 15:43 ` Arnaldo Carvalho de Melo
2015-07-29 16:12 ` Arnaldo Carvalho de Melo
2015-08-04 17:07 ` Liang, Kan
2015-08-04 17:53 ` Arnaldo Carvalho de Melo [this message]
2015-07-29 13:13 ` Jiri Olsa
2015-07-29 13:14 ` Jiri Olsa
2015-07-28 11:29 ` [PATCH V3 4/5] perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat kan.liang
2015-07-28 11:29 ` [PATCH V3 5/5] perf,tools: Show freq/CPU%/CORE_BUSY% in perf report --stdio kan.liang
2015-07-29 13:22 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804175334.GD3126@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox