From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbbHEBlI (ORCPT ); Tue, 4 Aug 2015 21:41:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49178 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751442AbbHEBlG (ORCPT ); Tue, 4 Aug 2015 21:41:06 -0400 Date: Wed, 5 Aug 2015 03:41:05 +0200 From: Alexandre Belloni To: Dmitry Torokhov Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 3/3] RTC: switch to using is_visible() to control sysfs attributes Message-ID: <20150805014105.GX3486@piout.net> References: <1437692468-24788-1-git-send-email-dmitry.torokhov@gmail.com> <1437692468-24788-3-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437692468-24788-3-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/07/2015 at 16:01:08 -0700, Dmitry Torokhov wrote : > Instead of creating wakealarm attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes are visible and which are not. This allows to to > create all needed attributes at once, at the same time that we register RTC > class device. > > Signed-off-by: Dmitry Torokhov Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com