From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbbHECEU (ORCPT ); Tue, 4 Aug 2015 22:04:20 -0400 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:32739 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbbHECET (ORCPT ); Tue, 4 Aug 2015 22:04:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DRBgB5bsFV/20mLHlbgxuBPalRAQEBAQEBBpsaAgIBAQKBPk0BAQEBAQGBC4QjAQEBBDocIxAIAxUDCSUPBSUDIROILcosAQEIAgEfGYYGhTCFCAeDGIEUAQSUeoxOjkmLDiaEDywxgkwBAQE Date: Wed, 5 Aug 2015 12:03:57 +1000 From: Dave Chinner To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH 04/11] ext4: Add ext4_get_block_dax() Message-ID: <20150805020357.GA3902@dastard> References: <1438718285-21168-1-git-send-email-matthew.r.wilcox@intel.com> <1438718285-21168-5-git-send-email-matthew.r.wilcox@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438718285-21168-5-git-send-email-matthew.r.wilcox@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 04, 2015 at 03:57:58PM -0400, Matthew Wilcox wrote: > From: Matthew Wilcox > > DAX wants different semantics from any currently-existing ext4 > get_block callback. Unlike ext4_get_block_write(), it needs to honour > the 'create' flag, and unlike ext4_get_block(), it needs to be able > to return unwritten extents. So introduce a new ext4_get_block_dax() > which has those semantics. We could also change ext4_get_block_write() > to honour the 'create' flag, but that might have consequences on other > users that I do not currently understand. > > Signed-off-by: Matthew Wilcox Doesn't this make the first patch in the series redundant? Cheers, Dave. -- Dave Chinner david@fromorbit.com