From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Adrian Remonda <adrianremonda@gmail.com>
Cc: devel@driverdev.osuosl.org, christian.gromm@microchip.com,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCHv5 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings
Date: Wed, 5 Aug 2015 10:54:10 +0530 [thread overview]
Message-ID: <20150805052410.GA4958@sudip-pc> (raw)
In-Reply-To: <1438713895-5961-2-git-send-email-adrianremonda@gmail.com>
On Tue, Aug 04, 2015 at 08:44:51PM +0200, Adrian Remonda wrote:
> This is a patch to the mostcore/core.c file. It makes
> several local functions and structures static to prevent global
> visibility.
>
> Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
> ---
<snip>
> @@ -1255,7 +1255,7 @@ static void arm_mbo(struct mbo *mbo)
> *
> * Returns the number of allocated and enqueued MBOs.
> */
> -int arm_mbo_chain(struct most_c_obj *c, int dir, void (*compl)(struct mbo *))
> +static int arm_mbo_chain(struct most_c_obj *c, int dir, void (*compl)(struct mbo *))
This introduced a new checkpatch warning about "line over 80
characters".
regards
sudip
prev parent reply other threads:[~2015-08-05 5:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 18:44 [PATCHv5 0/5] Staging: most: several warnings fix reported by sparse Adrian Remonda
2015-08-04 18:44 ` [PATCHv5 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-04 18:44 ` [PATCHv5 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-04 18:44 ` [PATCHv5 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-04 18:44 ` [PATCHv5 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-04 18:44 ` [PATCHv5 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-05 20:04 ` [PATCHv5 3/5] Staging: most: hdm-usb/hdm_usb.c. " Christian Gromm
2015-08-05 5:26 ` [PATCHv5 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Sudip Mukherjee
2015-08-05 5:24 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805052410.GA4958@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=adrianremonda@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox