* [PATCH -next] s390: lib: Export __delay
@ 2015-08-05 6:38 Guenter Roeck
2015-08-05 7:15 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2015-08-05 6:38 UTC (permalink / raw)
To: Martin Schwidefsky
Cc: Heiko Carstens, linux-s390, linux-kernel, Guenter Roeck,
Radha Mohan Chintakuntla, David Daney
__delay is exported by most architectures, and may be used in modules.
Since it is not exported for s390, s390:allmodconfig currently fails
to build with
ERROR: "__delay" [drivers/net/phy/mdio-octeon.ko] undefined!
Fixes: a6d678645210 ("net: mdio-octeon: Modify driver to work on both
ThunderX and Octeon")
Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
Cc: David Daney <david.daney@cavium.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/s390/lib/delay.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/lib/delay.c b/arch/s390/lib/delay.c
index 16dc42d83f93..246a7eb4b680 100644
--- a/arch/s390/lib/delay.c
+++ b/arch/s390/lib/delay.c
@@ -26,6 +26,7 @@ void __delay(unsigned long loops)
*/
asm volatile("0: brct %0,0b" : : "d" ((loops/2) + 1));
}
+EXPORT_SYMBOL(__delay);
static void __udelay_disabled(unsigned long long usecs)
{
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] s390: lib: Export __delay
2015-08-05 6:38 [PATCH -next] s390: lib: Export __delay Guenter Roeck
@ 2015-08-05 7:15 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2015-08-05 7:15 UTC (permalink / raw)
To: Guenter Roeck
Cc: Martin Schwidefsky, linux-s390, linux-kernel,
Radha Mohan Chintakuntla, David Daney
On Tue, Aug 04, 2015 at 11:38:23PM -0700, Guenter Roeck wrote:
> __delay is exported by most architectures, and may be used in modules.
> Since it is not exported for s390, s390:allmodconfig currently fails
> to build with
>
> ERROR: "__delay" [drivers/net/phy/mdio-octeon.ko] undefined!
>
> Fixes: a6d678645210 ("net: mdio-octeon: Modify driver to work on both
> ThunderX and Octeon")
> Cc: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> Cc: David Daney <david.daney@cavium.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/s390/lib/delay.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-05 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-05 6:38 [PATCH -next] s390: lib: Export __delay Guenter Roeck
2015-08-05 7:15 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).