From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752234AbbHEJKe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 5 Aug 2015 05:10:34 -0400
Received: from mail-wi0-f171.google.com ([209.85.212.171]:32768 "EHLO
	mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751343AbbHEJKa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 5 Aug 2015 05:10:30 -0400
Date: Wed, 5 Aug 2015 11:10:25 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Andy Lutomirski <luto@kernel.org>, Kees Cook <keescook@chromium.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        "security@kernel.org" <security@kernel.org>, X86 ML <x86@kernel.org>,
        Borislav Petkov <bp@alien8.de>, Sasha Levin <sasha.levin@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Jan Beulich <jbeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run
 time
Message-ID: <20150805091025.GA27542@gmail.com>
References: <1438626217-23970-1-git-send-email-w@1wt.eu>
 <20150804084911.GA24204@1wt.eu>
 <20150805080037.GA14472@gmail.com>
 <20150805080828.GA24964@1wt.eu>
 <20150805082616.GA18357@gmail.com>
 <20150805090311.GB24964@1wt.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150805090311.GB24964@1wt.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Willy Tarreau <w@1wt.eu> wrote:

> > > +	if (!sysctl_modify_ldt) {
> > > +		printk_ratelimited(KERN_INFO
> > > +			"Denied a call to modify_ldt() from %s[%d] (uid: %d)."
> > > +			" Adjust the modify_ldt sysctl if this was not an"
> > 
> > Would it really be so difficult to write this as:
> > 
> >   Set "sys.kernel.modify_ldt = 1" in /etc/sysctl.conf if this was not an exploit attempt.
> 
> It's just a matter of taste. Normally I consider the kernel distro-agnostic so I 
> don't like to suggest one way to adjust sysctls nor to reference config files. 
> Here we're in a case where only standard distro users may hit the issue, and 
> users of embedded distros will not face this message or will easily translate it 
> into their respective configuration scheme. So OK for this one.

So it's a side issue, but it's not a matter of taste at all: why should we end up 
hurting 99% of Linux users (that use regular distros), just to make it slightly 
more 'correct' for the weird 1% 'embedded distro' case that decided to put sysctl 
configuration elsewhere?

Users of 'embedded' distros won't normally see kernel messages, and even if they 
do, the message is crystal clear even to them...

Such messages should be as helpful to the regular case as possible. The weird 
cases will be OK too: and it does not help to make a message unhelpful for _both_ 
cases.

Thanks,

	Ingo