From: Tony Lindgren <tony@atomide.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vignesh R <vigneshr@ti.com>, Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree
Date: Wed, 5 Aug 2015 06:33:44 -0700 [thread overview]
Message-ID: <20150805133343.GL16878@atomide.com> (raw)
In-Reply-To: <20150803200246.GB38878@dtor-ws>
* Dmitry Torokhov <dmitry.torokhov@gmail.com> [150803 13:05]:
> On Mon, Aug 03, 2015 at 03:21:21AM -0700, Tony Lindgren wrote:
> >
> > Hmm why do we need the check for if (device_can_wakeup(&client->dev)))?
>
> Because of the code in device_wakeup_attach_irq():
>
> ws = dev->power.wakeup;
> if (!ws) {
> dev_err(dev, "forgot to call call device_init_wakeup?\n");
> return -EINVAL;
> }
OK :)
> > Also wondering about the dev vs &client->dev usage here.. But I take
> > you have checked that we end up calling the runtime PM calls of the
> > client instead of the i2c bus controller :)
>
> dev *is* clent->dev in this context:
>
> struct i2c_client *client = i2c_verify_client(dev);
OK thanks for confirming that.
Regards,
Tony
next prev parent reply other threads:[~2015-08-05 13:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 20:14 [PATCH] i2c: allow specifying separate wakeup interrupt in device tree Dmitry Torokhov
2015-07-31 10:57 ` Vignesh R
2015-08-03 10:21 ` Tony Lindgren
2015-08-03 20:02 ` Dmitry Torokhov
2015-08-05 13:33 ` Tony Lindgren [this message]
2015-08-09 15:22 ` Wolfram Sang
2015-08-10 5:59 ` Dmitry Torokhov
2015-08-10 6:16 ` Wolfram Sang
2015-08-19 17:43 ` Wolfram Sang
2015-08-19 17:51 ` Dmitry Torokhov
2015-08-24 12:33 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805133343.GL16878@atomide.com \
--to=tony@atomide.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).