From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, adrian.hunter@intel.com,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Vince Weaver <vince@deater.net>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH RFC v1 1/4] perf: Introduce extended syscall error reporting
Date: Wed, 5 Aug 2015 18:10:11 +0200 [thread overview]
Message-ID: <20150805161011.GO19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1437738359-23920-2-git-send-email-alexander.shishkin@linux.intel.com>
On Fri, Jul 24, 2015 at 02:45:56PM +0300, Alexander Shishkin wrote:
> @@ -3890,7 +3958,7 @@ perf_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
> ret = perf_read_hw(event, buf, count);
> perf_event_ctx_unlock(event, ctx);
>
> - return ret;
> + return perf_error_report(&event->attr, ret);
> }
>
> static unsigned int perf_poll(struct file *file, poll_table *wait)
> @@ -4103,7 +4171,7 @@ static long perf_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> ret = _perf_ioctl(event, cmd, arg);
> perf_event_ctx_unlock(event, ctx);
>
> - return ret;
> + return perf_error_report(&event->attr, ret);
> }
>
> #ifdef CONFIG_COMPAT
Oooh, shiny.. So not only does it work for SYSCALL time fails, it keeps
the pointer about and reports all subsequent fails in there too.
next prev parent reply other threads:[~2015-08-05 16:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 11:45 [PATCH RFC v1 0/4] perf: Introduce extended syscall error reporting Alexander Shishkin
2015-07-24 11:45 ` [PATCH RFC v1 1/4] " Alexander Shishkin
2015-07-30 12:09 ` Alexander Shishkin
2015-08-05 15:18 ` Peter Zijlstra
2015-08-05 15:35 ` Peter Zijlstra
2015-08-05 15:45 ` Peter Zijlstra
2015-08-17 12:51 ` Alexander Shishkin
2015-08-05 16:10 ` Peter Zijlstra [this message]
2015-07-24 11:45 ` [PATCH RFC v1 2/4] perf: Add file name and line number to perf extended error reports Alexander Shishkin
2015-07-24 11:45 ` [PATCH RFC v1 3/4] perf: Annotate some of the error codes with perf_err() Alexander Shishkin
2015-07-24 11:45 ` [PATCH RFC v1 4/4] perf/x86: " Alexander Shishkin
2015-08-05 17:01 ` [PATCH RFC v1 0/4] perf: Introduce extended syscall error reporting Peter Zijlstra
2015-08-22 13:51 ` Ingo Molnar
2015-08-24 13:52 ` Alexander Shishkin
2015-08-25 8:48 ` Ingo Molnar
2015-08-27 11:12 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805161011.GO19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox